Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jan 15, 2026

Summary

The security_password was last used in the personal setting security section, but already migrated to vue.
So it can be safely removed.

The styles can also be removed by moving the required ones directly to the Vue component.

Checklist

@susnux susnux added this to the Nextcloud 33 milestone Jan 15, 2026
@susnux susnux requested a review from a team as a code owner January 15, 2026 10:18
@susnux susnux removed the request for review from a team January 15, 2026 10:18
@susnux susnux added the 3. to review Waiting for reviews label Jan 15, 2026
@susnux susnux added feature: settings ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jan 15, 2026
@susnux susnux requested a review from CarlSchwan January 15, 2026 10:18
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

The `security_password` was last used in the personal setting security
section, but already migrated to vue.
So it can be safely removed.

The styles can also be removed by moving the required ones directly to
the Vue component.

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the chore/remove-dead-code branch from 7ef86ab to ddff2cb Compare January 15, 2026 15:20
@susnux susnux merged commit 13718c4 into master Jan 15, 2026
145 of 153 checks passed
@susnux susnux deleted the chore/remove-dead-code branch January 15, 2026 22:04
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: settings ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants